-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use cross to build binaries #507
base: v1.0
Are you sure you want to change the base?
Conversation
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
* v1.0: feat: MCP client sdk (#505)
- name: Set up Rust toolchain | ||
uses: actions-rust-lang/setup-rust-toolchain@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The toolchain actions-rust-lang/setup-rust-toolchain@v1
does not with cross. Not sure why.
We can use hermit in the future to set up the rust so that we have consistent environment locally and the build environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that is fine
I have tested all the generated binaries. Testing instructions are also documented in the doc I created in this PR
Link to generated binaries: https://github.com/block/goose/releases/tag/v_lifei.0.13 (I will clean this up later on)