Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use cross to build binaries #507

Open
wants to merge 45 commits into
base: v1.0
Choose a base branch
from
Open

Conversation

lifeizhou-ap
Copy link
Collaborator

@lifeizhou-ap lifeizhou-ap commented Dec 20, 2024

  • used rs-cross to build binaries
  • add doc for running cross build locally

I have tested all the generated binaries. Testing instructions are also documented in the doc I created in this PR

Link to generated binaries: https://github.com/block/goose/releases/tag/v_lifei.0.13 (I will clean this up later on)

* v1.0:
  Update cli-release.yml
  feat: added groq provider (#494)
  fix: use rust tls (#500)
  fix: Ldelalande/fix scroll (#504)
  feat: MCP server sdk (simple version first) (#499)
  tiny change to use most recent in stack (#501)
  stop bubbles filling screen (#495)
  chore: V1.0 release automation (#493)
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Lifei/aarch64 linux". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@lifeizhou-ap lifeizhou-ap changed the base branch from main to v1.0 December 20, 2024 05:24
@lifeizhou-ap lifeizhou-ap changed the title Lifei/aarch64 linux chore: Lifei/aarch64 linux Dec 20, 2024
@lifeizhou-ap lifeizhou-ap changed the title chore: Lifei/aarch64 linux chore: use cross to build binaries Dec 20, 2024
- name: Set up Rust toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toolchain actions-rust-lang/setup-rust-toolchain@v1 does not with cross. Not sure why.

We can use hermit in the future to set up the rust so that we have consistent environment locally and the build environment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that is fine

@lifeizhou-ap lifeizhou-ap marked this pull request as ready for review December 20, 2024 22:10
@lifeizhou-ap lifeizhou-ap requested a review from baxen December 20, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants