Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: form input #465

Merged
merged 6 commits into from
Jan 6, 2025
Merged

feat: form input #465

merged 6 commits into from
Jan 6, 2025

Conversation

michaelneale
Copy link
Collaborator

@michaelneale michaelneale commented Dec 13, 2024

This adds some fixes around asking for user input, and also lets goose ask for richer form input. Applies some more type checks around forms and options.

Screenshot 2024-12-13 at 2 47 49 PM

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

ui/desktop/src/utils/askAI.ts Outdated Show resolved Hide resolved
@michaelneale michaelneale requested a review from Copilot December 13, 2024 06:44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

ui/desktop/src/utils/askAI.ts:146

  • Correct the spelling mistake: 'descriribed' should be 'described'.
You must provide a response strictly as json in the format descriribed. No other

ui/desktop/src/utils/askAI.ts:33

  • Address the inconsistency in the getOptionsFormatterPrompt function. The example JSON response uses 'optionTitle' and 'optionDescription', but the actual implementation uses 'title' and 'description'.
getOptionsFormatterPrompt = (messageContent: string): string => `
* v1.0: (43 commits)
  feat: openrouter provider (#538)
  [ui] chore: tidy up gui providers (#537)
  [ui]: Polish and system theme fix (#533)
  [ui]: General ui polish to more closely match designs (#532)
  Latency issue fix with prepare_inference (#535)
  chore: use cross to build binaries (#507)
  feat: a system for non developers to augment developer system (#524)
  fix: Broken open directory and new session buttons in more menu (#520)
  refactor: move get_usage to provider trait (#506)
  fix: Make stop button more obvious (#516)
  fix: Enhance Dark mode menu dots visibility (#517)
  working on automating release of .zip and binaries and having them on each PR as well (#509)
  conditionally load memory system in goose server (#508)
  Adds 'instructions' field to InitializeResult (#511)
  feat: MCP client sdk (#505)
  Update cli-release.yml
  feat: added groq provider (#494)
  fix: use rust tls (#500)
  fix: Ldelalande/fix scroll (#504)
  feat: MCP server sdk (simple version first) (#499)
  ...
Copy link

github-actions bot commented Jan 6, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@michaelneale michaelneale merged commit b3b6cad into v1.0 Jan 6, 2025
6 checks passed
@michaelneale michaelneale deleted the micn/form-input branch January 6, 2025 22:23
lily-de pushed a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants