Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrappy version of feature flags for gui #452

Open
wants to merge 10 commits into
base: v1.0
Choose a base branch
from

Conversation

jsibbison-square
Copy link
Collaborator

@jsibbison-square jsibbison-square commented Dec 12, 2024

Enables us to merge in code that we want more user testing on without enabling it for everyone.

Adds a new menu option for Feature flags. After changing a feature flag you need to open a new chat window to see the effects.

Includes two examples feature flags:

  • Changing the splash 'what goose can do?' text
  • Changing the default tool output rendering between show by default or hide by default

Requires local storage to work atm. Over time should migrate to something more standard like https://openfeature.dev/ .

Screenshot 2024-12-12 at 3 09 17 pm

@jsibbison-square jsibbison-square changed the title WIP: Scrappy version of feature flags for gui Scrappy version of feature flags for gui Dec 12, 2024
@jsibbison-square jsibbison-square marked this pull request as ready for review December 12, 2024 04:31
@michaelneale
Copy link
Collaborator

michaelneale commented Dec 12, 2024

hrm - this seems a lot like a preferences screen vs flags (which are normally remotely controlled/optioned?)

I was thinking there could be an all on or all of thing from the file/window menu (something in main.ts) vs a seperate screen for preferences? (but interested what others think).

@jsibbison-square
Copy link
Collaborator Author

Closing this out pending future use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants