-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrappy version of feature flags for gui #452
Open
jsibbison-square
wants to merge
10
commits into
v1.0
Choose a base branch
from
jsibbison-20241212-gui-flags
base: v1.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsibbison-square
changed the title
WIP: Scrappy version of feature flags for gui
Scrappy version of feature flags for gui
Dec 12, 2024
hrm - this seems a lot like a preferences screen vs flags (which are normally remotely controlled/optioned?) I was thinking there could be an all on or all of thing from the file/window menu (something in main.ts) vs a seperate screen for preferences? (but interested what others think). |
Closing this out pending future use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables us to merge in code that we want more user testing on without enabling it for everyone.
Adds a new menu option for Feature flags. After changing a feature flag you need to open a new chat window to see the effects.
Includes two examples feature flags:
Requires local storage to work atm. Over time should migrate to something more standard like https://openfeature.dev/ .