Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update desktop-app-release.yaml #450

Open
wants to merge 2 commits into
base: v1.0
Choose a base branch
from
Open

fix: Update desktop-app-release.yaml #450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cac531
Update desktop-app-release.yaml
michaelneale Dec 11, 2024
0ff9a66
Update desktop-app-release.yaml
michaelneale Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions .github/workflows/desktop-app-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
push:
branches:
- v1.0
pull_request:
branches:
- v1.0

jobs:
build-and-bundle:
Expand Down Expand Up @@ -59,9 +62,6 @@ jobs:
- name: copy binary
run: cp target/release/goosed ui/desktop/src/bin/goosed




# Desktop App Steps
- name: Add MacOS certs for signing and notarization
run: ./add-macos-cert.sh
Expand All @@ -88,7 +88,21 @@ jobs:
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}

- name: Upload default
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Goose.zip
name: Goose_test.zip
path: ui/desktop/out/Goose-darwin-arm64/Goose.zip

- name: Comment on Pull Request with Artifact Link
if: ${{ github.event_name == 'pull_request' }}
uses: actions/github-script@v6
with:
script: |
const artifactUrl = `https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}`
const commentBody = `A new artifact has been created for this PR. You can download it [here](${artifactUrl}).`
github.rest.issues.createComment({
issue_number: ${{ github.event.pull_request.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: commentBody
})
Loading