fix: Don't do anything with an empty command #409
Conversation
crates/goose-cli/src/session.rs
Outdated
| @@ -107,6 +107,9 @@ impl<'a> Session<'a> { | |||
| match input.input_type { | |||
| InputType::Message => { | |||
| if let Some(content) = &input.content { | |||
| if content.trim().is_empty() { | |||
| continue; | |||
| } | |||
There was a problem hiding this comment.
I think it would be better to keep session.rs clear of any content parsing. Putting this logic in rustyline.rs where other user interaction elements are and returning. 'AskAgain' for this scenario is better I think.
aside: We should probably just delete cliclack.rs at this stage.
There was a problem hiding this comment.
Aha, yes, that seems better
There was a problem hiding this comment.
I think it would be better to keep session.rs clear of any content parsing. Putting this logic in rustyline.rs where other user interaction elements are and returning. 'AskAgain' for this scenario is better I think.
aside: We should probably just delete cliclack.rs at this stage.
|
Also snuck in a small change not to treat EOF/Cmd+D as an error. |
I tend to hit enter on a REPL to see that it's alive (maybe that's just me?). It seems correct to do nothing if there's no content typed here by the user.