-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: session management #402
Draft
Kvadratni
wants to merge
33
commits into
v1.0
Choose a base branch
from
mnovich/session-management
base: v1.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kvadratni
force-pushed
the
mnovich/session-management
branch
from
December 4, 2024 02:40
0a1ef2f
to
805a256
Compare
Kvadratni
force-pushed
the
mnovich/session-management
branch
from
December 4, 2024 02:46
805a256
to
52212a2
Compare
* v1.0: fix: speed improvement (#398)
… mnovich/session-management * origin/mnovich/session-management: SessionPills file rename + hook show recent ones always safe filenames style closer to design better sorting working end to end filter number of sessions and age now kind of works shifting to invoke Session management WIP
Kvadratni
force-pushed
the
mnovich/session-management
branch
from
December 4, 2024 19:06
f3e14ed
to
64ba52e
Compare
* refs/heads/v1.0: [app] Move dir selector - create more space on home screen [app] Node side error handling [app] Better error handling in chat # Conflicts: # ui/desktop/src/ChatWindow.tsx # ui/desktop/src/components/Splash.tsx
* refs/heads/v1.0: small fix (#416) fix: configure allows selecting the suggested option with return (#414) only publish default bundle of goose.app (#381) better icns standard size for macos updating goosed for dev time fix: Clippy for memory.rs fix: quick format fix: Remove insert command Lifei/configure key chain (#389) feat: Add welcome screen (#410) # Conflicts: # ui/desktop/src/ChatWindow.tsx # ui/desktop/src/main.ts
* refs/heads/v1.0: feat: Add cli options for configure to specify provider and model (#415) [app/ui] Add vibrancy effect to background
* refs/heads/v1.0: Extract common renderings (#432) fix: theme default (#431) anthropic provider (#420) fix: lib - add libxcb1-dev (#430) feat: launch GUI from shell (#423) [feat]: Dark mode support (#345) Update README.md (#426) fix: slow GUI with stdio (#425) Fixed icon position (#422) fix: replace empty window (#417) Download script for goose cli pre-release (#413) # Conflicts: # ui/desktop/src/ChatWindow.tsx # ui/desktop/src/components/Splash.tsx # ui/desktop/src/main.ts # ui/desktop/src/preload.js
* refs/heads/v1.0: feat: adding Resource objects, System.status to return list of Resources and trim when needed (#401)
Error: ENOENT: no such file or directory, mkdir '/Users/runner/.config/goose/sessions'
at Object.mkdirSync (node:fs:1371:26)
at Object.<anonymous> (/Users/runner/work/goose/goose/ui/desktop/.vite/build/main.js:3413:8)
at Module._compile (node:internal/modules/cjs/loader:1484:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1564:10)
at Module.load (node:internal/modules/cjs/loader:1295:32)
at Module._load (node:internal/modules/cjs/loader:[11](https://github.com/block/goose/actions/runs/12248205568/job/34167398970?pr=402#step:5:12)11:12)
at c._load (node:electron/js2c/node_init:2:16955)
at cjsLoader (node:internal/modules/esm/translators:350:17)
at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:286:7)
at ModuleJob.run (node:internal/modules/esm/module_job:234:25) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one - adds session management as per design so far:
Update: even more refinement
Screen.Recording.2024-12-04.at.3.30.41.PM.mov
Sessions are matched up with directory goose window is currently in (so it is a shorter list) - unless you go to the menu. Clicking on it will open the session. Sessions are saved automatically.
There is a bit of a refactor of ChatWindow.tsx as part of this to make it simpler so it could do this.
Session Management:
sessionManager.ts
.main.ts
with IPC handlers for saving, loading, and listing sessions.preload.js
to expose session management functions to the renderer process.LauncherWindow.tsx
to include new session-related methods in thewindow.electron
interface.