Libraries upgrade 1 (#449) #279
Annotations
22 warnings
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v1, actions/setup-node@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, actions/setup-node@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/Users/runner/work/blockcore/blockcore/src/Features/Persistence/Blockcore.Persistence.LevelDb/Blockcore.Persistence.LevelDb.csproj]
|
Nuget Pack:
src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/RocksDbChainStore.cs#L1
Provide an overridable implementation of Dispose(bool) on 'RocksDbChainStore' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Nuget Pack:
src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/RocksDbKeyValueRepository.cs#L1
Provide an overridable implementation of Dispose(bool) on 'RocksDbKeyValueRepository' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Nuget Pack:
src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/RocksDbKeyValueRepository.cs#L1
Modify 'RocksDbKeyValueRepository.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Nuget Pack:
src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/RocksDbChainStore.cs#L1
Modify 'RocksDbChainStore.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/Users/runner/work/blockcore/blockcore/src/Features/Persistence/Blockcore.Persistence.RocksDb/Blockcore.Persistence.RocksDb.csproj]
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/Users/runner/work/blockcore/blockcore/src/Features/Blockcore.Features.Dns/Blockcore.Features.Dns.csproj]
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/Users/runner/work/blockcore/blockcore/src/Features/Blockcore.Features.NodeHost/Blockcore.Features.NodeHost.csproj]
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/Users/runner/work/blockcore/blockcore/src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Unit Test:
src/Blockcore/NBitcoin/Bloom.cs#L1
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/AsyncWork/AsyncLoop.cs#L1
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeer.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/NBitcoin/BitcoinStream.cs#L1
Provide an overridable implementation of Dispose(bool) on 'Scope' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/Base/TimeSyncBehavior.cs#L1
Provide an overridable implementation of Dispose(bool) on 'TimeSyncBehaviorState' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerConnection.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerConnection' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerDisposer.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerDisposer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/Base/TipsManager.cs#L1
Provide an overridable implementation of Dispose(bool) on 'TipsManager' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerListener.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerListener' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerServer.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerServer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [/Users/runner/work/blockcore/blockcore/src/Blockcore/Blockcore.csproj]
|
Loading