Update xunit #287
Annotations
21 warnings
Unit Test:
src/Blockcore/NBitcoin/Bloom.cs#L1
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Unit Test:
src/Blockcore/AsyncWork/AsyncLoop.cs#L1
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/PeerConnector.cs#L1
Provide an overridable implementation of Dispose(bool) on 'PeerConnector' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Unit Test:
src/Blockcore/NBitcoin/BitcoinStream.cs#L1
Provide an overridable implementation of Dispose(bool) on 'Scope' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Unit Test:
src/Blockcore/Consensus/Chain/ChainRepository.cs#L1
Provide an overridable implementation of Dispose(bool) on 'ChainRepository' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeer.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerConnection.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerConnection' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Unit Test:
src/Blockcore/Consensus/ConsensusManager.cs#L1
Provide an overridable implementation of Dispose(bool) on 'ConsensusManager' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerDisposer.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerDisposer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Unit Test:
src/Blockcore/P2P/Peer/NetworkPeerListener.cs#L1
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerListener' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [D:\a\blockcore\blockcore\src\Blockcore\Blockcore.csproj]
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [D:\a\blockcore\blockcore\src\Features\Persistence\Blockcore.Persistence.RocksDb\Blockcore.Persistence.RocksDb.csproj]
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [D:\a\blockcore\blockcore\src\Features\Persistence\Blockcore.Persistence.LevelDb\Blockcore.Persistence.LevelDb.csproj]
|
Nuget Pack
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [D:\a\blockcore\blockcore\src\Features\Blockcore.Features.NodeHost\Blockcore.Features.NodeHost.csproj]
|
Nuget Pack:
src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/RocksDbChainStore.cs#L1
Provide an overridable implementation of Dispose(bool) on 'RocksDbChainStore' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Features\Persistence\Blockcore.Features.Base.Persistence.RocksDb\Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Nuget Pack:
src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/RocksDbKeyValueRepository.cs#L1
Provide an overridable implementation of Dispose(bool) on 'RocksDbKeyValueRepository' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Features\Persistence\Blockcore.Features.Base.Persistence.RocksDb\Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Nuget Pack:
src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/RocksDbKeyValueRepository.cs#L1
Modify 'RocksDbKeyValueRepository.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Features\Persistence\Blockcore.Features.Base.Persistence.RocksDb\Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Nuget Pack:
src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/RocksDbChainStore.cs#L1
Comparing a span to 'null' might be redundant, the 'null' literal will be implicitly converted to a 'Span<T>.Empty' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265) [D:\a\blockcore\blockcore\src\Features\Persistence\Blockcore.Features.Base.Persistence.RocksDb\Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Nuget Pack:
src/Features/Persistence/Blockcore.Features.Base.Persistence.RocksDb/RocksDbChainStore.cs#L1
Modify 'RocksDbChainStore.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063) [D:\a\blockcore\blockcore\src\Features\Persistence\Blockcore.Features.Base.Persistence.RocksDb\Blockcore.Features.Base.Persistence.RocksDb.csproj]
|
Nuget Pack:
src/Features/Blockcore.Features.Diagnostic/Utils/ConcurrentFixedSizeQueue.cs#L1
Make 'ConcurrentFixedSizeQueue' sealed (a breaking change if this class has previously shipped), implement the method non-explicitly, or implement a new method that exposes the functionality of 'System.Collections.ICollection.get_SyncRoot' and is visible to derived classes (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1033) [D:\a\blockcore\blockcore\src\Features\Blockcore.Features.Diagnostic\Blockcore.Features.Diagnostic.csproj]
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "Blockcore-1.2.41-ubuntu-latest-preview", "Blockcore-1.2.41-windows-latest-preview".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Loading