-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VIDEO-3086] Configure gst-plugins-rs source, ref #18
[VIDEO-3086] Configure gst-plugins-rs source, ref #18
Conversation
Signed-off-by: Thomas Goodwin <[email protected]>
a504b93
to
3acc266
Compare
This patch release includes our aws3sink w/ cache and intersink changes
I'm stumped. Earlier I let it run with a different existing tag and it was fine. Now it's not with the new tag. Their readme says "branch"...which won't be great; the variable is called commits after all. |
The spec for git reset --hard is <commit>, which does accept a remote name but goes to the head of the branch (`remote/branch` format). If we need to target a tag, our tag must be unique.
Look'n good. It made it past the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to also update the config-hash
calculation. I'd suggest something simple like:
config_hash=$(echo "${CERBERO_ARGS}${{ inputs.config }}${GST_PLUGINS_RS_SOURCE}${GST_PLUGINS_RS_REF}" | sha256sum | cut -d' ' -f1)
These were suggestions from PR comments. Co-authored-by: Jeff Wilson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the build passes.
@jawilson Well, it's through the wickets but I can't merge to the branch because it's protected. I assume you have permission? |
Got a little carried away with the branch protection rulesets. I couldn't merge either. Updated and good to merge now. |
Updated the github action to add
recipes_remotes
andrecipes_commits
into the configuration file, pointinggst-plugins-rs
at our repository. The target including the following two changes is0.12.9-lldc.1
, here.