fix compiler warning about mismatched allocator (#28)

The buffer(s) here are created with 'new' but free'd with 'free' when it should have been 'delete []', resulting in a compiler warning that may or may not cause issues. Signed-off-by: Thomas Goodwin <[email protected]> Co-authored-by: sara boulé <[email protected]>
blinemedical · Feb 23, 2024 · fe412dd · fe412dd
1 parent 337280d
commit fe412dd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/gsts3uploaderpartcache.hpp b/src/gsts3uploaderpartcache.hpp
@@ -190,7 +190,7 @@ class UploaderPartCache {
 
         void clear_buffer() {
             if (_buffer) {
-                free(_buffer);
+                delete [] _buffer;
             }
             _buffer = NULL;
         }

diff --git a/tests/check/uploaderpartcache.cpp b/tests/check/uploaderpartcache.cpp
@@ -24,7 +24,7 @@
 using gst::aws::s3::UploaderPartCache;
 
 #define TEST_BUFFER_NEW(s) (new char[s])
-#define TEST_BUFFER_FREE(b) {if (b) free(b); b = NULL;}
+#define TEST_BUFFER_FREE(b) {if (b) delete [] b; b = NULL;}
 
 GST_START_TEST(test_part_info) {
   UploaderPartCache::PartInfo uut;