Juliano/op 677 add user badge #132
Open
+904
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
juliano-quatrin-nunes
changed the base branch from
main
to
juliano/op-676-ui-for-achievements-page
ribeirojose
reviewed
Jan 16, 2025
apps/govquests-api/rails_app/app/graphql/resolvers/fetch_special_badge.rb
Show resolved
Hide resolved
Base automatically changed from
juliano/op-676-ui-for-achievements-page
to
main
January 16, 2025 21:28
juliano-quatrin-nunes
force-pushed
the
juliano/op-677-add-user-badge
branch
from
89877a4 to
3174a14
Compare
ribeirojose
reviewed
Jan 20, 2025
ribeirojose
reviewed
Jan 20, 2025
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-frontend/src/domains/gamification/graphql/specialBadgeQuery.ts
Show resolved
Hide resolved
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-frontend/src/domains/gamification/graphql/badgesQuery.ts
Outdated
Show resolved
Hide resolved
ribeirojose
reviewed
Jan 20, 2025
| withTitle | ||
| header={`BADGE #${index + 1}`} | ||
| header={`${badge.badgeable.__typename} BADGE #${badge.displayData.sequenceNumber}`} |
There was a problem hiding this comment.
Can you trust the typename to be something readable?
There was a problem hiding this comment.
I have done some testing and I think yes, it's supposed to be either Quest or Track
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-frontend/src/domains/action_tracking/hooks/useCompleteActionExecution.ts
Show resolved
Hide resolved
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-api/rails_app/db/migrate/20250115203038_make_badgeable_optional_in_badges.rb
Outdated
Show resolved
Hide resolved
ribeirojose
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Blocking this until apps/govquests-api/rails_app/db/migrate/20250115203038_make_badgeable_optional_in_badges.rb is resolved is resolved
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-api/rails_app/app/read_models/questing/user_track_read_model.rb
Show resolved
Hide resolved
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-api/rails_app/app/read_models/questing/on_track_created.rb
Show resolved
Hide resolved
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-api/rails_app/app/read_models/gamification/user_badge_read_model.rb
Outdated
Show resolved
Hide resolved
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-api/rails_app/app/read_models/gamification/user_badge_read_model.rb
Show resolved
Hide resolved
ribeirojose
reviewed
Jan 20, 2025
| validates :display_data, presence: true | ||
| validates :badge_type, presence: true | ||
| validates :badge_data, presence: true | ||
| validates :points, presence: true, numericality: {only_integer: true, greater_than_or_equal_to: 0} |
There was a problem hiding this comment.
Remind me -- users will get these after satisfying a set of requirements, right?
There was a problem hiding this comment.
Yes! I'm creating something related to this on #138
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-api/rails_app/app/read_models/gamification/on_badge_earned.rb
Outdated
Show resolved
Hide resolved
ribeirojose
reviewed
Jan 20, 2025
apps/govquests-api/rails_app/app/read_models/gamification/badge_read_model.rb
Show resolved
Hide resolved
ribeirojose
reviewed
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented:
Not implemented:
Preview:
Screen.Recording.2025-01-16.at.18.24.56.mov