Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preferential gauge] Frontend PoC #547

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

luizakp
Copy link
Contributor

@luizakp luizakp commented Dec 22, 2023

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cow-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 5:11pm

<h3 className="mb-2 leading-3 text-slate11">{description}</h3>
</div>
{link && (
<a target="_blank" href={link} className="text-slate12">

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
@luizakp luizakp marked this pull request as ready for review December 26, 2023 21:45
mendesfabio
mendesfabio previously approved these changes Jan 31, 2024
packages/gql/src/balancer-gauges/gauge.ts Outdated Show resolved Hide resolved
packages/gql/src/balancer-gauges/gauge.ts Outdated Show resolved Hide resolved
Comment on lines +30 to +37
gauges {
gauge {
liquidityGauge {
id
symbol
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gauges {
gauge {
liquidityGauge {
id
symbol
}
}
}
gauges {
id
symbol
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to ignore if it causes much trouble down the line, but gauges already has id and symbol and you can use it

@ribeirojose
Copy link
Contributor

Do you need any help fixing the conflicts and merging this @luizakp ?

@luizakp
Copy link
Contributor Author

luizakp commented Feb 27, 2024

Do you need any help fixing the conflicts and merging this @luizakp ?

ops forgot I can merge this 😅

@ribeirojose
Copy link
Contributor

Do you need any help fixing the conflicts and merging this @luizakp ?

ops forgot I can merge this 😅

😬

@yvesfracari
Copy link
Contributor

Are we still planning to merge this? If not we can just close the PR. @luizakp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants