feat: trigger extra hook simulation on order review #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvesfracari
force-pushed
the
pedro/cow-trigger-simulation-on-order-review
branch
from
b7fce79 to
389608d
Compare
yvesfracari
force-pushed
the
pedro/cow-414-make-hook-gas-limit-override-it-with-tenderly-simulation
branch
from
d2b652d to
1745ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since simulations are only triggered on hook changes, sometimes the user can't see that the hook is falling. This PR adds one extra simulation on the order review.
Screenshare.-.2024-11-08.10_35_42.AM.mp4
To Test
You can follow the same process that I did on the video.