Add order details links, reset fields on advanced configs close, balance validation, and add remove draft orders dialog #56
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| selectedIds.length === draftOrders.length && | ||
| !!draftOrders.length |
There was a problem hiding this comment.
what happens when the user manually deselects one of the orders?
There was a problem hiding this comment.
It also deselects the select all checkbox
| @@ -78,8 +78,15 @@ export function AdvancedSettingsDialog() { | |||
|
|
|||
| const receiver = useWatch({ control, name: "receiver" }); | |||
|
|
|||
| const handleOpenChange = (isOpen: boolean) => { | |||
| if (!isOpen) { | |||
| reset(advancedSettings); | |||
There was a problem hiding this comment.
🤔 why do we need this here?
There was a problem hiding this comment.
CoW Feedback:
"When I update settings fields, then close the modal without pressing on the Save button, the values I've changes are remain to be displayed in the fields.
However, the changes are not applied when place an order. This moght be confising to a user: settings show different info than order review modal.
So here I can propose 2 options:
- Remove 'Save' button and auto-save all changes made on the Settings modal
- OR reset changes to defaults when close settings modal without pressing on the Save button"
This is to implement the second solution.
yvesfracari
changed the title
* add action menu on tables to invert price * run formater and linter * increase test timeout
No description provided.