Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions and links on the menus #12

Merged

Conversation

yvesfracari
Copy link
Contributor

No description provided.

Copy link

linear bot commented Mar 7, 2024

COW-137 Add descriptions and links on the menus

As was done on the milkman project. Use tooltips with input description. Oracles should also forward to chainlink price feed list.

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composable-cow-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 3:16pm

@yvesfracari yvesfracari marked this pull request as ready for review March 7, 2024 12:30
Validity Bucket Time
</label>
<div className="flex flex-row justify-between">
<FormLabel className="mb-2 block text-sm text-slate12">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Lu had worked on adding a tooltip to the form label, hadn't you @luizakp ? 🤔 thinking about how we can avoid working on the same things here

Copy link
Contributor

@ribeirojose ribeirojose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only left a note about the doubled work we've been doing in some components cc @luizakp

@yvesfracari yvesfracari merged commit 3535b2a into main Mar 11, 2024
4 checks passed
@yvesfracari yvesfracari deleted the pedro/cow-137-add-descriptions-and-links-on-the-menus branch July 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants