add new repo structure #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeirojose
force-pushed
the
jose/cowpy-2-setup-base-repo-structure
branch
4 times, most recently
from
5b60086 to
9b852ce
Compare
ribeirojose
force-pushed
the
jose/cowpy-2-setup-base-repo-structure
branch
from
9b852ce to
bfc594f
Compare
ribeirojose
force-pushed
the
jose/cowpy-2-setup-base-repo-structure
branch
from
f2859b7 to
6af0426
Compare
ribeirojose
force-pushed
the
jose/cowpy-2-setup-base-repo-structure
branch
from
e3dd4e7 to
e21122d
Compare
ribeirojose
force-pushed
the
jose/cowpy-2-setup-base-repo-structure
branch
from
06c9abf to
89c7114
Compare
yvesfracari
approved these changes
Feb 20, 2024
cow_py/core/__init__.py
Outdated
| @@ -0,0 +1,4 @@ | |||
| from cow_py.core import constants, cow_error, abis, chains, config | |||
There was a problem hiding this comment.
would use the same name of the ts package (common)
cow_py/core/chains/__init__.py
Outdated
Comment on lines
25
to
29
| CHAIN_SCANNER_MAP = { | ||
| Chain.MAINNET: "https://etherscan.io", | ||
| Chain.GNOSIS: "https://gnosisscan.io", | ||
| Chain.SEPOLIA: "https://sepolia.etherscan.io/", | ||
| } |
There was a problem hiding this comment.
i don't think that we will need this
There was a problem hiding this comment.
I'll leave it here for now though
| @@ -1,4 +1,5 @@ | |||
| # cow-py | |||
|
|
|||
mfw78
approved these changes
Feb 20, 2024
cow_py/core/constants.py
Outdated
There was a problem hiding this comment.
FYI, on this, I think we would at some stage want to change the upstream cow-sdk to have contracts as a module within, so you could have:
- contracts module
- within the contracts module, the abi.
So all consumers of the cow-py don't have to worry about ABI encoding etc (ie. shouldn't have to touch it at all, and the SDK can do it for them).
I won't hold up the merge on this, and happy for you to roll forward 🛼
There was a problem hiding this comment.
agreed! Just sent a commit with those changes 😄
mendesfabio
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3