Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time as input type #91

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Add Time as input type #91

merged 3 commits into from
Aug 20, 2024

Conversation

luizakp
Copy link
Contributor

@luizakp luizakp commented Aug 7, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced the DatePickerInput component with improved styling for better responsiveness.
    • Expanded the InputField component to support an additional input mode for time, improving versatility and usability.
  • Bug Fixes
    • Addressed stacking context issues with the popover in the DatePickerInput component.

Copy link

coderabbitai bot commented Aug 7, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent updates to the DatePickerInput and InputField components significantly enhance their responsiveness and usability within the form builder. Notable improvements include refined styling for better layout consistency, as well as the introduction of a new input type ("time") in the InputField, enriching the user experience while preserving the original functionalities of both components.

Changes

Files Change Summary
src/components/FormBuilder/fields/... Improved styling for DatePickerInput with full-width layout and z-index adjustments; expanded InputFieldProps to include a new mode ("time"), adjusting rendering logic accordingly.

Poem

In fields where data flows so bright,
Our forms now dance with pure delight!
With time in hand and width to share,
Each input shines with thoughtful care.
Hooray for changes, let’s all cheer,
For user joy is finally here! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -56,7 +57,7 @@ export const InputField = withConditional<InputFieldProps>(
}
defaultValue={field.defaultValue}
render={({ field: formField }) => (
<FormItem className="w-full">
<FormItem className={cn( field.mode === "time" ? "w-[240px]": "w-full")}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bleu-ui ❌ Failed (Inspect) Aug 20, 2024 2:39pm

@luizakp luizakp merged commit aa43f41 into main Aug 20, 2024
3 of 4 checks passed
@luizakp luizakp deleted the time-input branch August 20, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants