Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External link display option to data table #70

Merged
merged 9 commits into from
Apr 29, 2024

Conversation

devjoaov
Copy link
Contributor

No description provided.

@devjoaov devjoaov requested review from ribeirojose and luizakp April 29, 2024 12:27
@devjoaov devjoaov self-assigned this Apr 29, 2024
Copy link

linear bot commented Apr 29, 2024

CLICK-743

className="underline text-primary flex items-center"
>
<Trans>Open</Trans>&nbsp;
<span>{column.columnDef.title}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#could use radix's external link or link2: https://www.radix-ui.com/icons
Screenshot 2024-04-29 at 9 36 15 AM
Screenshot 2024-04-29 at 9 36 10 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#would add tooltip

@@ -7,16 +7,31 @@ import { cn } from "#/lib/utils";

const ToastProvider = ToastPrimitives.Provider;

const toastViewPortVariants = cva(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@devjoaov devjoaov force-pushed the joao/click-743-simbolod-e-coracao-e-favoritar branch from 62a0dcc to eb4f380 Compare April 29, 2024 13:18
@devjoaov devjoaov merged commit d6cee5e into main Apr 29, 2024
2 checks passed
@devjoaov devjoaov deleted the joao/click-743-simbolod-e-coracao-e-favoritar branch April 29, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants