Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests to FormBuilder components #69

Merged
merged 5 commits into from
Apr 29, 2024
Merged

add tests to FormBuilder components #69

merged 5 commits into from
Apr 29, 2024

Conversation

ribeirojose
Copy link
Contributor

@ribeirojose ribeirojose commented Apr 28, 2024 •
edited
Loading

  • fix(RichTextEditor): refactor JoditEditor import
  • refactor(Form): refactor to make more performant
  • test(FormBuilder): add tests to FormBuilder elements
Before (~2%) After ( ~47%)
Screenshot 2024-04-28 at 8 34 07 AM Screenshot 2024-04-28 at 8 34 57 AM

@ribeirojose ribeirojose changed the title add tests to form add tests to form components Apr 28, 2024
@ribeirojose ribeirojose changed the title add tests to form components add tests to FormBuilder components Apr 28, 2024
@ribeirojose ribeirojose requested review from devjoaov and luizakp April 28, 2024 10:41
@ribeirojose ribeirojose force-pushed the add-tests-to-form branch 2 times, most recently from d210d79 to d4720c7 Compare April 28, 2024 11:28
ribeirojose
ribeirojose commented Apr 28, 2024
View reviewed changes
tests/components/FormBuilder/FormField.test.tsx
);
};

// it("renders the correct error message when validation fails", async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't make this work 😢 lmk if you want to try it out @devjoaov otherwise I'll just remove them and merge without it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a task for that

devjoaov
devjoaov approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@devjoaov devjoaov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, I don't have experience testing frontend components so I'll trust your judgment here 👍

@devjoaov devjoaov merged commit a4fa758 into main Apr 29, 2024
2 checks passed
@devjoaov devjoaov deleted the add-tests-to-form branch April 29, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devjoaov devjoaov devjoaov approved these changes

@luizakp luizakp Awaiting requested review from luizakp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ribeirojose @devjoaov