pkp/pkp-lib#10444 Remove inline class for icon title in the Dialog co… (

pkp#452) * pkp/pkp-lib#10444 Remove inline class for icon title in the Dialog component * pkp/pkp-lib#10444 Remove font-size css rule when displaying close button in Modal component
blesildaramirez · Nov 27, 2024 · 145ce66 · 145ce66
1 parent a67fd26
commit 145ce66
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/components/Modal/Dialog.vue b/src/components/Modal/Dialog.vue
@@ -49,11 +49,7 @@
 									:class="icon ? 'pb-5' : 'pb-8'"
 								>
 									<div v-if="icon" :class="iconStyles">
-										<Icon
-											:icon="icon"
-											:inline="true"
-											class="h-11 w-11 text-on-dark"
-										></Icon>
+										<Icon :icon="icon" class="h-11 w-11 text-on-dark"></Icon>
 									</div>
 									<span class="px-4">{{ title }}</span>
 								</DialogTitle>

diff --git a/src/components/Modal/Modal.vue b/src/components/Modal/Modal.vue
@@ -290,7 +290,6 @@ export default {
 		margin-inline-start: auto; // fix position when no title exists
 		margin-inline-end: 0.5rem;
 		border: none;
-		font-size: @font-lead;
 		line-height: 1;
 		width: 2rem;
 		height: 2rem;