Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of charges #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

antoineluong
Copy link

This change is meant to facilitate later additions of charges by regrouping all data relative to a particular charge inside a dedicated class that can be inherited.

@antoineluong
Copy link
Author

Some remarks:

  • the encoding/decoding system is left unimplemented (is it useful?)
  • I am not sure how to adapt the fast-check tests

@blemoine
Copy link
Owner

Ok, first sorry for the delay; I dont' really have time to maintain this project (which was originally a toy project :) ) .
Because I don't want to block any dev you would want to do on it, I can if you want Write a big "DEPRECATED" on my project, with a link to your fork ? That way you will be able to merge/deploy whatever you want

The encoding/decoding was originally thought to be the first step toward support for image recognition of blason: if you can represent a blason as a vector, you can train a neural network that way. I never had time to work on that, so it can be trashed, I guess.

As this is a toy project, I set some restriction to myself, like "don't use classes" (I'm a functionnal programmer lover). As it seems your don't really follow this philosophy, it's all the more a reason for you to work on your fork (instead of fighting each other on petty things like "is inheritance a bad thing?").

Sorry to not be more available at the moment :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants