Single Point Downloader #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ibarlet! Thanks for this PR. I'm just took a quick look. When I have a little more time I'll look more. (The failure for the macos-latest test is something I ran into a few months back in Herbie, I just need to remember what I needed to change.) |
…ture/local-data-accessor
|
Thanks for adding this and providing a notebook with examples. Feel free to provide any updates if you feel anything is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential solution for #84
Allows you to open a series of sequential scans focused entirely one one latitude/longitude point. You must still download each individual full scan. However, this should require only holding a the single x-y point in memory per scan and so allow you to efficiently work with a longer time period than is normally possible.
This PR also fixes some depreciation errors by updating
Htohin a few places. I think these changes fix #75Future work could include adding a pandas output with the datetime as the index and finding the nearest non-nan point.