Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: macOS Homebrew CI #8

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Fix: macOS Homebrew CI #8

merged 2 commits into from
Sep 30, 2023

Conversation

dragonmux
Copy link
Member

This PR aims, with many thanks to @amyspark for her help figuring this out, to enable the Homebrew part of the CI matrix and guard against the GCC bug we were inadvertently triggering.

With this, all CI jobs for macOS are enabled and working.

@dragonmux dragonmux added Bug Confirmed bug CI Continuous Integration System OS: macOS Something specific to macOS labels Sep 29, 2023
@dragonmux dragonmux added this to the v1.0 milestone Sep 29, 2023
@dragonmux dragonmux requested a review from esden September 29, 2023 01:06
@dragonmux dragonmux force-pushed the fix/macos-homebrew-ci branch from b6ad6f5 to ff8ce59 Compare September 29, 2023 01:25
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #8 (ff8ce59) into main (f87ad30) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main      #8   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         30      30           
  Lines       1568    1568           
  Branches     495     495           
=====================================
- Misses      1530    1531    +1     
+ Partials      38      37    -1     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit 4ef64a7 into main Sep 30, 2023
@dragonmux dragonmux deleted the fix/macos-homebrew-ci branch September 30, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug CI Continuous Integration System OS: macOS Something specific to macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants