Skip to content

Commit

Permalink
workflows: declare empty BUILD_OPTS
Browse files Browse the repository at this point in the history
While reading the workflow files without previous knowledge the use BUILD_OPTS variable is confusing, it's not clear where it comes from, or if it even is populated, this makes it clear it is just a statically empty variable for now, and can be populated if needed in the future
  • Loading branch information
rg-silva authored and dragonmux committed Sep 28, 2023
1 parent b98c62c commit 665f83f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/build-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ jobs:
- 'gcc-12'
- 'gcc-13'
fail-fast: false
env:
BUILD_OPTS: ''
steps:
- name: Runtime environment
shell: bash
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ jobs:
- gcc@12
- gcc@13 # needs hardcoding for the GCOV replacement
fail-fast: false
env:
BUILD_OPTS: ''
steps:
- name: Runtime environment
env:
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
CC: cl.exe
CXX: cl.exe
LD: link.exe
BUILD_OPTS: ''
steps:
- name: Runtime environment
env:
Expand Down Expand Up @@ -111,6 +112,8 @@ jobs:
- ucrt64
- clang64
fail-fast: false
env:
BUILD_OPTS: ''
steps:
- name: Use MinGW from MSYS
uses: msys2/setup-msys2@v2
Expand Down Expand Up @@ -154,7 +157,7 @@ jobs:
meson --version
ninja --version
- name: Configure
run: meson build --prefix=$HOME/.local
run: meson build --prefix=$HOME/.local $BUILD_OPTS
- name: Build
run: meson compile -C build
- name: Test
Expand Down

0 comments on commit 665f83f

Please sign in to comment.