Fix: s32k3xx: Remove the single assert #1900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
assert()
which pullsfiprintf()
and_vfiprintf_r
again, resulting in extra 1.5 KiB of newlib stdio.replacing the assert with a logged runtime error.IIUC target flash layer should call it with alen=writesize
. Depending on review and API guarantees I can drop even that. Update: dropped.I expect a significant size-diff from CI. This should restore the effect of my previous #1513.
Cannot test on hardware. CC @via.
Your checklist for this pull request
Closing issues