Feature: declarations cleanup #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
added
Enhancement
dragonmux
force-pushed
the
feature/decls-cleanup
branch
from
a36e265 to
e712744
Compare
43 tasks
dragonmux
force-pushed
the
feature/decls-cleanup
branch
2 times, most recently
from
fa4d708 to
4aaf963
Compare
…ot get LTO-optimised out
…k_target_voltage()`
dragonmux
force-pushed
the
feature/decls-cleanup
branch
from
4aaf963 to
441e95b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
In this PR we aim to tie up some loose ends from the Meson build system's introduction, including the spate of new warnings, and some low-hanging UB that attempting LTO builds finds.
With these changes building normally should now be warnings-free. This also cleans up from the semihosting PRs by moving some straggler enums to the correct files as much as possible and fixing naming around them.
This fixes some more of the classes of warning targeted by the list in #1590
Your checklist for this pull request
Closing issues