Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target/flashstub: fix variable initialization in stm32f1_flash_write_… #1702

Merged
merged 1 commit into from
Dec 18, 2023
Merged

target/flashstub: fix variable initialization in stm32f1_flash_write_… #1702

merged 1 commit into from
Dec 18, 2023

Conversation

francois-berder
Copy link
Contributor

Detailed description

This PR ensures that the loop counter is initialized to 0 in stm32f1_flash_write_stub function.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

None.

dragonmux
dragonmux approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Interesting this wasn't found before.. well, LGTM so merging. Thank you for the contribution!

@dragonmux dragonmux added this to the v2.0 release milestone Dec 18, 2023
@dragonmux dragonmux added the Bug Confirmed bug label Dec 18, 2023
@dragonmux dragonmux merged commit 8c15dd4 into blackmagic-debug:main Dec 18, 2023
6 checks passed
@francois-berder francois-berder deleted the fix-var-init branch December 19, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bug
Projects
None yet
Milestone
v2.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@francois-berder @dragonmux