Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: Convert format-string in rtt #1682

Merged
merged 1 commit into from
Nov 14, 2023
Merged

command: Convert format-string in rtt #1682

merged 1 commit into from
Nov 14, 2023

Conversation

koendv
Copy link
Contributor

@koendv koendv commented Nov 14, 2023

Detailed description

Detailed description

This PR brings the format strings in cmd_rtt up to date, removing gcc -Wformat errors, but keeping existing functionality.
See #1676

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thanks for the contribution!

@dragonmux dragonmux added this to the v2.0 release milestone Nov 14, 2023
@dragonmux dragonmux added Bug Confirmed bug Enhancement General project improvement labels Nov 14, 2023
@dragonmux dragonmux merged commit 83388f4 into blackmagic-debug:main Nov 14, 2023
6 checks passed
@ALTracer
Copy link
Contributor

Yes, thank you, I'm acknowledging this fixes rtt-related format warnings from gdb_outf() in src/command.c when that's declared as void gdb_outf(const char *fmt, ...) __attribute__((format(printf, 1, 2))) (change pending, not in main).

@koendv koendv deleted the rtt branch November 15, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants