Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: BMDA SWD no_check routines #1660

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix: BMDA SWD no_check routines #1660

merged 1 commit into from
Oct 30, 2023

Conversation

dragonmux
Copy link
Member

Detailed description

This PR fixes a small bug that crept in when merging #1549 due to the API change in decode_access().

This broke the build due to a missing parameter.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added this to the v2.0 release milestone Oct 29, 2023
@dragonmux dragonmux added Bug Confirmed bug BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Regression Bug caused by a regression labels Oct 29, 2023
@dragonmux dragonmux requested a review from esden October 29, 2023 23:19
esden
esden approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, quick catch :)

@esden esden merged commit 7fcb788 into main Oct 30, 2023
6 checks passed
@dragonmux dragonmux deleted the fix/bmda-swd-no-check-routines branch October 30, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esden esden esden approved these changes

Assignees
No one assigned
Labels
BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Bug Confirmed bug Regression Bug caused by a regression
Projects
None yet
Milestone
v2.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@dragonmux @esden