-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: samd: Implemented support for the SAMC21 series #1659
Conversation
Before we go and review this, please correct your commit message to comply with the contribution guidelines. This modifies the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of items to address, one of which technical rather than stylistic. With those addressed and the commit message point sorted, this looks good and we'll be happy to accept the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now needs rebasing on main
due to #1662, but once done we'll mark it as accepted and merge. Thank you for fixing those issues.
OK, thanks.
If I then try "mon swd" a second time it's instantaneous; no error message; works fine. |
Please could you use BMDA and run |
Detailed description
This PR adds a new target: Atmel SAMC21.
The PR was tested on a Atmel SAMC21N18A (rev E) M0+, with parameters:
SAMD_DID_MASK was changed from 0xff380000U to 0xfe380000U.
This allows SAMC21 parts where DID begins with 0x11 to be accepted.
SAMD_DID_FAMILY_MASK was changed from 0x3fU to 0x1fU.
According to the datasheet, the field "family" in the DID Device Identification Register is a 5 bit field, so the mask ought to be 0x1f, not 0x3f.
sample gdb session attached:
samc21.txt
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues
fixes #890