Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: BMDA AP access decoding #1641

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix: BMDA AP access decoding #1641

merged 1 commit into from
Oct 11, 2023

Conversation

dragonmux
Copy link
Member

@dragonmux dragonmux commented Oct 5, 2023

Detailed description

This PR addresses an issue found with @desertsagebrush's help where the AP for a request would always be decoded for DEBUG_PROTO display as being AP 1.

This PR also addresses the same function's (decode_access()) handling of the AP/!DP bit in the address value passed to it.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

…operly decode the AP/!DP bit in the address field so we display accesses properly
@dragonmux dragonmux added this to the v1.10 milestone Oct 5, 2023
@dragonmux dragonmux added Bug Confirmed bug BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Regression Bug caused by a regression labels Oct 5, 2023
@dragonmux dragonmux requested a review from esden October 5, 2023 02:05
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit 9fe5889 into main Oct 11, 2023
6 checks passed
@dragonmux dragonmux deleted the fix/bmda-ap-access-decoding branch October 11, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Bug Confirmed bug Regression Bug caused by a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants