Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for TM4C AP duplication #1636

Merged

Conversation

desertsagebrush
Copy link
Contributor

@desertsagebrush desertsagebrush commented Oct 2, 2023

Detailed description

This provides an escape out of the AP initialization process for Tiva processors (like the TM4C1294KCDT) that incorrectly report the same AP multiple times. Developed in discussion with dragonmux when adding support for the aforementioned processor

Note that as this specifically checks for the string Tiva in the driver field, this does not prevent an unknown-to-BMP (Tiva or other) processor from spitting out 255 extra APs (or however many the native hardware will do before running out of memory).

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

@dragonmux dragonmux added this to the v1.10 milestone Oct 2, 2023
@dragonmux dragonmux added Bug Confirmed bug HwIssue Mitigation Solving or mitigating a Hardware issue in Software labels Oct 2, 2023
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us save for one small layout oops in the multi-line comment - good comment though!

We'll get this merged once that's sorted.

src/target/adiv5.c Outdated Show resolved Hide resolved
@desertsagebrush desertsagebrush force-pushed the fix/tm4c_ap_duplication branch from d61fc96 to 01f387d Compare October 2, 2023 23:57
@desertsagebrush desertsagebrush force-pushed the fix/tm4c_ap_duplication branch from 01f387d to a38382d Compare October 2, 2023 23:59
@dragonmux
Copy link
Member

LGTM, Merging once the builds finish.

@dragonmux dragonmux merged commit 85b9463 into blackmagic-debug:main Oct 3, 2023
6 checks passed
@desertsagebrush desertsagebrush deleted the fix/tm4c_ap_duplication branch October 3, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug HwIssue Mitigation Solving or mitigating a Hardware issue in Software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants