Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: timer setup Flash usage #1631

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Fix: timer setup Flash usage #1631

merged 2 commits into from
Sep 28, 2023

Conversation

dragonmux
Copy link
Member

Detailed description

ALTracer was kind enough to point out on Discord that the timer setup code for BMP introduced in #1615 also wound up introducing ~400 bytes of extra Flash usage for a single function - timer_set_oc_mode() - so this PR, in combination with some changes to libopencm3, addresses this.

This results in a 332 byte saving.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added Enhancement General project improvement BMP Firmware Black Magic Probe Firmware (not PC hosted software) labels Sep 27, 2023
@dragonmux dragonmux added this to the v1.10 milestone Sep 27, 2023
@dragonmux dragonmux requested a review from esden September 27, 2023 22:17
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for fixing it. :)

@esden esden merged commit 08583c1 into main Sep 28, 2023
6 checks passed
@dragonmux dragonmux deleted the fix/timer-setup-flash-usage branch September 28, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMP Firmware Black Magic Probe Firmware (not PC hosted software) Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants