Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cortex-A support #1626

Merged
merged 8 commits into from
Sep 20, 2023
Merged

Fix: Cortex-A support #1626

merged 8 commits into from
Sep 20, 2023

Conversation

dragonmux
Copy link
Member

Detailed description

In this PR we set out to complete the replacement of the apb_read() and apb_write() functions in the Cortex-A code using the newer cortex_dbg_read32() and cortex_dbg_write32() functions as the former functions make gross assumptions about the state and configuration of the AP that no longer hold.

This had resulted in scan-then-crash issues on targets and would have caused issues on any part that has both a Cortex-M and Cortex-A core on the same Access Port as the Cortex-M code would have caused the same state inconsistency problem.

This also reduces the Flash footprint for the Cortex-A support by ~200 bytes.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added Bug Confirmed bug Regression Bug caused by a regression labels Sep 19, 2023
@dragonmux dragonmux added this to the v1.10 milestone Sep 19, 2023
@dragonmux dragonmux requested a review from esden September 19, 2023 23:49
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@esden esden merged commit d0189bb into main Sep 20, 2023
6 checks passed
@dragonmux dragonmux deleted the fix/cortex-a-support branch September 20, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug Regression Bug caused by a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants