Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
In this PR we set out to complete the replacement of the
apb_read()
andapb_write()
functions in the Cortex-A code using the newercortex_dbg_read32()
andcortex_dbg_write32()
functions as the former functions make gross assumptions about the state and configuration of the AP that no longer hold.This had resulted in scan-then-crash issues on targets and would have caused issues on any part that has both a Cortex-M and Cortex-A core on the same Access Port as the Cortex-M code would have caused the same state inconsistency problem.
This also reduces the Flash footprint for the Cortex-A support by ~200 bytes.
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues