Fix: JTAG correctness #1384
Merged
Fix: JTAG correctness #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap_init()'s calling jtagtap_soft_reset() duplicates work
…n not initialising jtag_proc.tap_idle_cycles, breaking things subtly
… don't overcomplicate things
…e far too narrow and it was causing clock glitch pulses
… handling in jtagtap_tdi_tdo_seq() broken, and added lots of documentation on what's going on
… fix a setup-and-hold timing violation
…AVR support branches
esden
approved these changes
Feb 12, 2023
|
Ahahaha, indeed! and unfortunately not the last time we're going to have to touch jtagtap.c either as we know there's at least one more problem based on how JTAG-PDI ran today.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
In this PR we address several JTAG bugs (including a regression from PR #1131) which were impacting the ability for the firmware to correctly talk to RISC-V targets, among others. There are still issues with the timings being very tight on many devices, but this does at least appear to be reliable and gives reasonable clocking waveforms too as shown in the capture below.
This blocks PR #1380 till merged and must be applied on top of that PR if wishing to test RISC-V with BMP or other BMD firmware platforms.
Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues