target: add weak aliasing to allow disabling targets #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the chain of includes that made it so this fails with my changes, supposedly doesn't touch any of that |
|
doesn't make much sense, it should have been failing before? |
dragonmux
requested changes
Jul 25, 2022
Signed-off-by: Rafael Silva <[email protected]>
Signed-off-by: Rafael Silva <[email protected]>
perigoso
force-pushed
the
feature/target_disabling
branch
from
72a2a47 to
2709f67
Compare
|
I thought about adding a debug message to warn that a probe method was called that has been disabled at build time, but left it for a future commit/pr if there's interest to not block this |
dragonmux
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #1033
This PR doesn't actually allow (easily) the disabling targets, just lays some groundwork for it, and cleans a couple things up
Signed-off-by: Rafael Silva [email protected]