target: Replace remaining sprintf calls with snprintf

* These cases in efm32, sam3x, stm32l0 store a string into bounded priv_storage * Pass its size as second argument, as done everywhere else
blackmagic-debug · May 13, 2024 · bd8fd9e · bd8fd9e
1 parent 7933ed3
commit bd8fd9e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/target/efm32.c b/src/target/efm32.c
@@ -960,7 +960,8 @@ bool efm32_aap_probe(adiv5_access_port_s *ap)
 	DEBUG_INFO("EFM32: AAP STATUS=%08" PRIx32 "\n", adiv5_ap_read(ap, AAP_STATUS));
 
 	efm32_aap_priv_s *priv_storage = calloc(1, sizeof(*priv_storage));
-	sprintf(priv_storage->aap_driver_string, "EFM32 Authentication Access Port rev.%hu", aap_revision);
+	snprintf(priv_storage->aap_driver_string, sizeof(priv_storage->aap_driver_string),
+		"EFM32 Authentication Access Port rev.%hu", aap_revision);
 	t->driver = priv_storage->aap_driver_string;
 	t->regs_size = 0;
 

diff --git a/src/target/sam3x.c b/src/target/sam3x.c
@@ -407,9 +407,9 @@ bool samx7x_probe(target_s *t)
 	sam_add_flash(t, SAMX7X_EEFC_BASE, 0x00400000, priv_storage->descr.flash_size);
 	target_add_commands(t, sam_cmd_list, "SAMX7X");
 
-	sprintf(priv_storage->sam_variant_string, "SAM%c%02d%c%d%c", priv_storage->descr.product_code,
-		priv_storage->descr.product_id, priv_storage->descr.pins, priv_storage->descr.density,
-		priv_storage->descr.revision);
+	snprintf(priv_storage->sam_variant_string, sizeof(priv_storage->sam_variant_string), "SAM%c%02d%c%d%c",
+		priv_storage->descr.product_code, priv_storage->descr.product_id, priv_storage->descr.pins,
+		priv_storage->descr.density, priv_storage->descr.revision);
 
 	t->driver = priv_storage->sam_variant_string;
 	return true;

diff --git a/src/target/stm32l0.c b/src/target/stm32l0.c
@@ -258,7 +258,8 @@ bool stm32l0_probe(target_s *const target)
 	const uint32_t nvm = stm32lx_nvm_phys(target);
 	const bool protected =
 		(target_mem32_read32(target, STM32Lx_NVM_OPTR(nvm)) & STM32Lx_NVM_OPTR_RDPROT_M) != STM32Lx_NVM_OPTR_RDPROT_0;
-	sprintf(priv_storage->stm32l_variant, "%s%s", target->driver, protected ? " (protected)" : "");
+	snprintf(priv_storage->stm32l_variant, sizeof(priv_storage->stm32l_variant), "%s%s", target->driver,
+		protected ? " (protected)" : "");
 	target->driver = priv_storage->stm32l_variant;
 
 	if (protected) {