semihosting: Fixed a warning being produced from the BMDA SYS_OPEN code

blackmagic-debug · Jan 14, 2024 · 52095d9 · 52095d9
1 parent e8d1629
commit 52095d9
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/target/semihosting.c b/src/target/semihosting.c
@@ -393,8 +393,9 @@ int32_t semihosting_open(target_s *const target, const semihosting_s *const requ
 		O_WRONLY | O_CREAT | O_APPEND, /* a, ab */
 		O_RDWR | O_CREAT | O_APPEND,   /* a+, a+b */
 	};
-	const int32_t native_open_mode =
-		native_open_mode_flags[request->params[1] >> 1U] | ((request->params[1] & 1U) ? O_BINARY : 0U);
+	int32_t native_open_mode = native_open_mode_flags[request->params[1] >> 1U];
+	if (request->params[1] & 1U)
+		native_open_mode |= O_BINARY;
 
 	const int32_t result = open(file_name, native_open_mode | O_NOCTTY, 0644);
 	target->tc->gdb_errno = semihosting_errno();