Skip to content

Commit

Permalink
stm32f4: Added a note about the operation of stm32f4_attach() that sh…
Browse files Browse the repository at this point in the history
…ould be revised at a later date
  • Loading branch information
dragonmux committed May 11, 2024
1 parent 5d761f6 commit 5013700
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/target/stm32f4.c
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,10 @@ static uint32_t stm32f4_remaining_bank_length(const uint32_t bank_length, const
return 0;
}

/*
* XXX: It would definitely be nice if all this soup of logic could reasonably be refactored and moved into
* the stm32f4_probe() routine as this is doing work that should not be repeated every attach.
*/
static bool stm32f4_attach(target_s *target)
{
/* First try and figure out the Flash size (if we don't know the part ID, warn and return false) */
Expand Down

0 comments on commit 5013700

Please sign in to comment.