-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread pool #138
base: develop
Are you sure you want to change the base?
Thread pool #138
Conversation
…ution using htslib
…e also now copy the front of the dhtslib.file iterators with dup
Codecov Report
@@ Coverage Diff @@
## develop #138 +/- ##
===========================================
+ Coverage 83.37% 83.78% +0.41%
===========================================
Files 45 46 +1
Lines 4823 4945 +122
===========================================
+ Hits 4021 4143 +122
Misses 802 802
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
What is the use case? I may not be qualified to comment on this 🤯 |
@@ -199,6 +199,13 @@ void ks_free(kstring_t* s) | |||
} | |||
} | |||
|
|||
kstring_t* ks_dup(kstring_t* s) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly is not a part of kstring.h or kstring.c ; will this make it more difficult to keep your file in sync with upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have the diff system, probably not. Though I should update the diffs considering I have new changes that need to carry forward.
Though I also thought that kstring
already had a dup
function and was surprised to find that it didn't.
This PR adds wrappers around
htsThreadPool
andhts_tpool
. The goal would be to allow parallel, in-order execution of arbitrary functions. These jobs could be added directly to the same thread pools that are used for reading and writing files.