replace env var based configuration with toml #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
env vars just turned out to not work great setting them just isn't a very well defined thing, especially within the same process and across threads we've run into constant issues with people not having the env vars propagte properly originally we thought this was just a proton thing, but it's become increasingly more common on windows too decided on using toml since it's relatively human friendly, it's used by python which we use downstream, and it kind of fits well with the idea of downstream projects using the same config file with their own settings
the readme's needed a bit of a redo for a while, taking the excuse of needing to update the settings to do so
realized we can't safely expose a string view cross dll (in the config struct) axing the config struct makes this a lot more similar to the old code it also means we're not storing an extra copy of half the values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.