Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #50

Merged
merged 16 commits into from
Mar 4, 2024
Merged

Dev #50

merged 16 commits into from
Mar 4, 2024

Conversation

bjornoleh
Copy link
Owner

No description provided.

bewest and others added 16 commits October 20, 2023 08:20
Releasing 15.0.1, hotfix to revert series of changes affecting mongodb that were not quite ready.
The allowEIO3, when set to true allows v2 clients to connect while the
default is false. This patch should allow versions of AndroidAPS older
than 3.2 to connect to NS15 and above.
Thanks to Dave Carlson for researching and experimenting with this
option!
https://socket.io/docs/v4/migrating-from-2-x-to-3-0/#how-to-upgrade-an-existing-production-deployment
https://socket.io/docs/v4/server-options/#alloweio3
This patch removes my own patch to enable allowEIO3 in
favor of @thecubic's patch. They both do the same thing, but
@thecubic's is tested.
socket.io: enable legacy v2 connections
This patch is intended to allow customizing the behavior for whether or not to
prompt for authorization before subscribing or acknolweding alarms.
There was a bug in previous attempts where the profileeditor would be double
initialized, causing the profileeditor to remove some buttons from the GUI.
This patch adds checking for a permission specifically related to acknolwedging
alarms, as well as avoids double-initializing the editor, which causes the
issue with the GUI.
This patch eliminates debugging logging in favor of commentary to capture how,
where, and why alarmSocket feature is causing different pages to demand the
authentication prompt in a variety of circumstances.
Create an opportunity to respond with something other than a global ack when
someone that is not authorized sends an acknolwedgement to an alarm.
Eliminate double-initializing when subscribing to alarms. The `callback`
variable is not local to the function, anyway.
When someone is looking at Nightscout and needs the alarm silenced, it is very
desirable to always silence the local UI. This patch documents some of the
working code around handling the alarm notification process, as well as
provides commentary on handling unauthorized scenarios.  There are some open
questions such as how to update the permission set after authorization.
alarmSocket: customizing authorization requirements
Dev branch for next release, 15.0.2
@bjornoleh bjornoleh merged commit 25db928 into bjornoleh:bo-dev Mar 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants