Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #48

Merged
merged 3 commits into from
Sep 13, 2023
+7 −5
Merged

Dev #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79df562
npm install nightscout-connect@^0.0.11
bewest Aug 25, 2023
9f2f98b
allow client to load successfully without requiring API SECRET
bewest Sep 3, 2023
5488df4
Merge pull request #8085 from nightscout/wip/bewest/api-secret-free-r…
bewest Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/client/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ client.load = function load (serverSettings, callback) {
}

console.log('Subscribed for alarms', data);
if (!data.success) {
if (client.settings.authenticationPromptOnLoad && !data.success) {
client.hashauth.requestAuthentication(function afterRequest () {
client.hashauth.updateSocketAuth();
if (callback) {
Expand Down
2 changes: 2 additions & 0 deletions lib/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ function init () {
, adminNotifiesEnabled: true
, obscured: ''
, obscureDeviceProvenance: ''
, authenticationPromptOnLoad: false
};

var secureSettings = [
Expand Down Expand Up @@ -111,6 +112,7 @@ function init () {
, bgTargetBottom: mapNumber
, authFailDelay: mapNumber
, adminNotifiesEnabled: mapTruthy
, authenticationPromptOnLoad: mapTruthy
};

function filterObj(obj, secureKeys) {
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"mongo-url-parser": "^1.0.2",
"mongodb": "^3.6.0",
"mongomock": "^0.1.2",
"nightscout-connect": "0.0.10",
"nightscout-connect": "^0.0.11",
"node-cache": "^4.2.1",
"parse-duration": "^0.1.3",
"process": "^0.11.10",
Expand Down