Merge pull request nightscout#8085 from nightscout/wip/bewest/api-sec…

…ret-free-reads Wip/bewest/api secret free reads
bjornoleh · Sep 3, 2023 · 5488df4 · 5488df4
2 parents d602de1 + 9f2f98b
commit 5488df4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/lib/client/index.js b/lib/client/index.js
@@ -1146,7 +1146,7 @@ client.load = function load (serverSettings, callback) {
         }
 
         console.log('Subscribed for alarms', data);
-        if (!data.success) {
+        if (client.settings.authenticationPromptOnLoad && !data.success) {
           client.hashauth.requestAuthentication(function afterRequest () {
             client.hashauth.updateSocketAuth();
             if (callback) {

diff --git a/lib/settings.js b/lib/settings.js
@@ -72,6 +72,7 @@ function init () {
     , adminNotifiesEnabled: true
     , obscured: ''
     , obscureDeviceProvenance: ''
+    , authenticationPromptOnLoad: false
   };
 
   var secureSettings = [
@@ -111,6 +112,7 @@ function init () {
     , bgTargetBottom: mapNumber
     , authFailDelay: mapNumber
     , adminNotifiesEnabled: mapTruthy
+    , authenticationPromptOnLoad: mapTruthy
   };
 
   function filterObj(obj, secureKeys) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -116,7 +116,7 @@
     "mongo-url-parser": "^1.0.2",
     "mongodb": "^3.6.0",
     "mongomock": "^0.1.2",
-    "nightscout-connect": "0.0.10",
+    "nightscout-connect": "^0.0.11",
     "node-cache": "^4.2.1",
     "parse-duration": "^0.1.3",
     "process": "^0.11.10",