-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#208 support for Lines between markers added to JVectorMap #431
base: master
Are you sure you want to change the base?
Conversation
hi fdominik, |
I am not really sure if I understand correctly. BTW.: I have an update to thus pull request, where I have added toggle switch next to zoom buttons to allow switching on/off the lines on the map. However I am still not satisfied with results (CSS is not my strongest skill) so I will push this later when I will resolve it. |
thank u for you answer! |
@fdominik Thanks for your awesome work. The only problem is that it seems we can only set color for one line? |
@gezichenshan oh indeed, I didn't have this in mind when doing it. I am thinking, is it already working anywhere in jvectormap? I think markers can also have only one color, am I right? |
@selinafocus I am not sure about the transformation. I haven't used the processor transformation, maybe some unit tests would be nice to see where it doesn't work. |
@fdominik Thank you for your reply. Setting a new property "color" is a good choice. Anyway, maybe there is no need to set different color for different line. I am not good at graphic, either. May somebody can help :) |
I have added support for creating lines between markers (or rather a points defined by Lat and Long). There is not much functionality (like creating Arcs), but styling of Lines and Line Labels works.
Lines can be defined as:
The best to test the functionality is to see lines.html page.