Remove normalized assertions from mul_quat
#560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes sense to ensure that quaternions are normalized before using them to do things that require them to be normalized to make sense (like transforming a vector), but it is entirely valid to multiply non-normalized quaternions. Such a use case is in implementing dual quaternions, in which case we routinely multiply the (normalized) real-part quat with the (non-normalized in and of itself) dual-part quat.