codegen: Fix missing parameter c and types in mul_add for fma
#297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running into a bunch of:
error[E0425]: cannot find value `c` in this scope
--> .cargo/registry/src/github.com-1ecc6299db9ec823/glam-0.21.0/src/f32/sse2/vec3a.rs:626:35
|
626 | _mm_fmadd_ps(self, b, c)
| ^ help: a local variable with a similar name exists: `a`
And:
error[E0308]: mismatched types
--> .cargo/registry/src/github.com-1ecc6299db9ec823/glam-0.21.0/src/f32/sse2/vec3a.rs:626:26
|
626 | _mm_fmadd_ps(self, b, c)
| ^^^^ expected struct `std::arch::x86_64::__m128`, found struct `f32::sse2::vec3a::Vec3A`
On the new 0.21 release when building for a CPU with FMA, introduced by
the new codegen in bitshifter#294. These are trivially fixable by updating the
template.
|
Ah I missed that. FMA doesn't get built by CI :/ Thanks! |
|
Yeah I assumed as much, it's sad but nothing too bad :) Perhaps a custom GH runner can be hosted somewhere? Cross-compilation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into a bunch of:
And:
On the new 0.21 release when building for a CPU with FMA, introduced by the new codegen in #294. These are trivially fixable by updating the template.