CUDA setup cleanup #996
Merged
CUDA setup cleanup #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "sort compute capabilities" fix from bitsandbytes-foundation#703 (bitsandbytes-foundation#527) would actually do nothing due to this.
wkpark
reviewed
Jan 30, 2024
This was referenced Jan 30, 2024
Merged
wkpark
approved these changes
Feb 1, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
wkpark
approved these changes
Feb 1, 2024
younesbelkada
approved these changes
Feb 1, 2024
|
Amazing work, once more! |
Titus-von-Koeller
merged commit 259ad44
into
bitsandbytes-foundation:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on #873 (and #703/#527) to slightly clean up the CUDA setup and diagnostics code.
The last commit is the most interesting code-wise; #703/#527 added the sensible-enough behavior to sort CUDA version strings as sequences of integers, but since the retval was again re-sorted in
evaluate_cuda_setup(), the sort was a no-op.This removes the "dumber" sort from
evaluate_cuda_setup().Honestly, I think there's a lot more simplification possible in the CUDA setup and diagnostics code, but that's maybe for a future PR...