add audit wheel to CI/CD for visibility of many_linux conformance #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
akx
approved these changes
Mar 7, 2024
.github/workflows/python-package.yml
Outdated
Comment on lines
199
to
207
| for whl in dist/*.whl; do | ||
| printf '%.0s=' {1..60} # separator line, same as below | ||
| echo -e "\nChecking wheel: $whl" | ||
| printf '%.0s-' {1..60} | ||
| echo | ||
| auditwheel show "$whl" | ||
| printf '%.0s-' {1..60} | ||
| echo | ||
| done |
There was a problem hiding this comment.
A future version of this could use https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary for ✨markdown✨ but this is a good start. This could also be a separate step that's done after all of the wheels are done.
There was a problem hiding this comment.
ok, took a moment to give you the fancy output you desire when waiting for other results..
Titus-von-Koeller
force-pushed
the
add-auditwheel-show-to-ci
branch
from
1327e4e to
0de046c
Compare
akx
reviewed
Mar 8, 2024
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Download all wheel artifacts | ||
| uses: actions/download-artifact@v2 |
There was a problem hiding this comment.
You can't use download-artifact@v2 with upload-artifact@v4, which is probably why you're not getting anything here :)
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
akx
added a commit
to akx/bitsandbytes
that referenced
this pull request
Mar 8, 2024
Closes bitsandbytes-foundation#1114 Co-authored-by: Titus von Koeller <[email protected]>
|
closed in favor of #1116 |
Titus-von-Koeller
added a commit
that referenced
this pull request
Mar 11, 2024
Closes #1114 Co-authored-by: Titus von Koeller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.