restore BUILD_* options #1044
restore BUILD_* options #1044
Conversation
* support both BUILD_* and COMPUTE_BACKEND options
|
What is the expected outcome of |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| set_property(CACHE COMPUTE_BACKEND PROPERTY STRINGS cpu cuda mps) | ||
| option(PTXAS_VERBOSE "Pass through -v flag to PTX Assembler" OFF) | ||
|
|
||
| if(APPLE) | ||
| set(CMAKE_OSX_DEPLOYMENT_TARGET 13.1) | ||
| endif() | ||
|
|
||
| option(BUILD_CUDA "Build bitsandbytes with CUDA support" OFF) |
There was a problem hiding this comment.
This allows specifying both MPS and CUDA at the same time, which will fail as it is now. What is the expected outcome?
There was a problem hiding this comment.
previously implemented CMakeLists.txt does not do much and, BUILD_MPS even not work currently.
| set_property(CACHE COMPUTE_BACKEND PROPERTY STRINGS cpu cuda mps) | ||
| option(PTXAS_VERBOSE "Pass through -v flag to PTX Assembler" OFF) | ||
|
|
||
| if(APPLE) | ||
| set(CMAKE_OSX_DEPLOYMENT_TARGET 13.1) | ||
| endif() | ||
|
|
||
| option(BUILD_CUDA "Build bitsandbytes with CUDA support" OFF) | ||
| option(BUILD_MPS "Build bitsandbytes with MPS support" OFF) | ||
| option(NO_CUBLASLT "Disable CUBLAS" OFF) |
There was a problem hiding this comment.
This option is only valid when building for CUDA
There was a problem hiding this comment.
NO_CUBLASLT was old Makefile stuff and previously implemented CMakeLists.txt does not break its old behavior.
There was a problem hiding this comment.
Is it important not to break the old Makefile flags?
|
|
||
| if(${COMPUTE_BACKEND} STREQUAL "cuda") | ||
| if("${COMPUTE_BACKEND}" STREQUAL "cuda") | ||
| if(APPLE) | ||
| message(FATAL_ERROR "CUDA is not supported on macOS" ) |
There was a problem hiding this comment.
This check is ignored when specifying -DBUILD_CUDA=ON, but redundant since done on line 63
|
The documentation for the command has been updated in PR #1047, close this issue. |
BUILD_*andCOMPUTE_BACKENDoptionsinternally
COMPUTE_BACKEND=cpu|cuda|mpsuseBUILD_*options, so we can support old options with minor fix.COMPUTE_BACKENDif it is available. (default value is "") => "cpu" build will be selected.cpu" without any given options. (previously default is "BUILD_CUDA=ON")with this fix, we can restore the oldMakefilebehavior.